Skip to content

HHH-19707 - Include value column name in TableStructure InitCommand #10747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2025

Conversation

rayudu3745
Copy link
Contributor

https://hibernate.atlassian.net/browse/HHH-19707
When @GeneratedValue(strategy = GenerationType.TABLE) is used with Cloud Spanner(using google maintained dialect, the generator’s InitCommand INSERT statement fails because it does not explicitly list the target column names.

Cloud Spanner requires all INSERT statements to specify column names — even when inserting into a single-column table. Since Hibernate’s default table generator omits the column list in its InitCommand , Spanner rejects the statement, preventing the sequence table from being initialized.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


Copy link
Member

@gavinking gavinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM, let's wait to see how if the tests pass.

@gavinking gavinking merged commit 18499fa into hibernate:main Aug 13, 2025
23 of 24 checks passed
@gavinking
Copy link
Member

Merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants